Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configuration twice #243

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Remove configuration twice #243

merged 3 commits into from
Sep 21, 2024

Conversation

montythind
Copy link
Contributor

Removed create solver method and consolidated the camp file logic creation of solver in one method

closes #217

K20shores
K20shores requested changes Sep 20, 2024
View reviewed changes
src/acom_music_box/main.py Outdated Show resolved Hide resolved
src/acom_music_box/music_box.py Outdated Show resolved Hide resolved
src/acom_music_box/music_box.py Outdated Show resolved Hide resolved
tests/integration/test_analytical.py Outdated Show resolved Hide resolved
tests/integration/test_carbon_bond_5.py Outdated Show resolved Hide resolved
tests/integration/test_chapman.py Outdated Show resolved Hide resolved
tests/integration/test_flow_tube.py Outdated Show resolved Hide resolved
tests/unit/test_callback.py Outdated Show resolved Hide resolved
@K20shores
Copy link
Collaborator

Looking good! Just a few minor things

K20shores
K20shores approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@K20shores K20shores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@montythind montythind merged commit f1c8c27 into main Sep 21, 2024
4 checks passed
@montythind montythind deleted the remove_configuration_twice_217 branch September 21, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K20shores K20shores K20shores approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the need to provide the configuration twice
2 participants
@montythind @K20shores